Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vispy test #17

Merged
merged 19 commits into from
Jun 24, 2024
Merged

Add vispy test #17

merged 19 commits into from
Jun 24, 2024

Conversation

tlambert03
Copy link
Contributor

pulling this test out from #14 ... this would add a basic vispy volume rendering test, if you're ok with that

@tlambert03 tlambert03 marked this pull request as ready for review June 22, 2024 21:29
@tlambert03
Copy link
Contributor Author

i think this is ready for review @larsoner
mostly it's just "extra" testing. I'm not sure whether it covers anything specifically outside of what is already covered with the existing pyvista and qt tests... but vispy in qt is such a common use case for me that it would be nice to have the assurance :)

@larsoner larsoner merged commit 4cf5c60 into pyvista:main Jun 24, 2024
12 checks passed
@larsoner
Copy link
Collaborator

Great, thanks @tlambert03 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants